Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Margins not only for Box #256

Merged
merged 10 commits into from
Jul 13, 2020
Merged

feat: Margins not only for Box #256

merged 10 commits into from
Jul 13, 2020

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Jul 8, 2020 •
edited
Loading

Expand the usage of Margins to accept any kind of React element that accepts a className prop.

N.B.: you can't override Margins elements by composing them, i.e., this:

<Margins all='x16'>
  <Margins all='x8'>
    <div />
  </Margins>
</Margins>

will not have a defined behavior.

@tassoevan tassoevan requested a review from a team July 8, 2020 18:42
@tassoevan tassoevan mentioned this pull request Jul 9, 2020
Merged
@tassoevan tassoevan marked this pull request as draft July 10, 2020 23:48
@tassoevan tassoevan marked this pull request as ready for review July 11, 2020 00:48
ggazzo
ggazzo previously approved these changes Jul 13, 2020
View reviewed changes
@ggazzo ggazzo merged commit 94e71a8 into develop Jul 13, 2020
@ggazzo ggazzo deleted the feat/margins-for-non-box branch July 13, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo left review comments

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo